Target .NET 10 for HtmlRenderer.Core and HtmlRenderer.WinForms#246
Open
kushanp wants to merge 2 commits into
Open
Target .NET 10 for HtmlRenderer.Core and HtmlRenderer.WinForms#246kushanp wants to merge 2 commits into
kushanp wants to merge 2 commits into
Conversation
Keep the Core package reference aligned with the latest .NET 10 servicing release.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes HtmlRenderer.Core and HtmlRenderer.WinForms for .NET 10, with related safety and API fixes.
Targeting
net10.0(wasnetstandard2.0;net8.0)net10.0-windowswithUseWindowsForms+NullableSystem.Resources.Extensions→ 10.0.10Bug / safety fixes
IntPtrinstead of truncatedint)ImageDownloaderclient list + dedicated lock inImageLoadHandlerHtmlToolTipdispose unsubscription order + null/handle guardsSetHtml, selection getters, entityEquals)Editorattribute assembly names for .NET 10Breaking change
This drops multi-targeting for Core (
netstandard2.0/net8.0). Consumers on older TFMs need to multi-target or stay on a previous release. Happy to adjust to multi-target (net8.0+net10.0) if preferred.Scope
Only Core + WinForms (no WPF / PdfSharp / Demo changes).
Test plan
dotnet build -c ReleaseHtmlRenderer.csproj (net10.0)dotnet build -c ReleaseHtmlRenderer.WinForms.csproj (net10.0-windows)HtmlPanel/HtmlContainer.SetHtml(null)Notes
Rebased onto current
master(includes upstream dependency + GHA updates).A follow-up PR will add HtmlPanel zoom/pan as a separate feature.